Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement warnings #105

Closed
CasperWA opened this issue Dec 2, 2019 · 0 comments · Fixed by #431
Closed

Implement warnings #105

CasperWA opened this issue Dec 2, 2019 · 0 comments · Fixed by #431
Assignees
@CasperWA
Labels
enhancement New feature or request help wanted Extra attention is needed priority/medium Issue or PR with a consensus of medium priority
Milestone
OPTiMaDe v0.10.0

Comments

@CasperWA
Copy link
Member

CasperWA commented Dec 2, 2019

It would be cool to add something similar to the Exception handlers for Warnings.

Perhaps it could be done with middleware? Or something similar.

What I have in mind is to catch from warnings import warn warnings and add them, as per the OPTiMaDe spec, under meta.warnings.
@CasperWA CasperWA added enhancement New feature or request help wanted Extra attention is needed labels Dec 2, 2019
@CasperWA CasperWA added this to the OPTiMaDe v0.10.0 milestone Dec 22, 2019
@CasperWA CasperWA changed the title Add warnings Implement warnings Jan 6, 2020
@CasperWA CasperWA added the priority/medium Issue or PR with a consensus of medium priority label Feb 5, 2020
@CasperWA CasperWA mentioned this issue Jul 27, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CasperWA CasperWA

Labels
enhancement New feature or request help wanted Extra attention is needed priority/medium Issue or PR with a consensus of medium priority
Projects
None yet
Milestone
OPTiMaDe v0.10.0
Development

Successfully merging a pull request may close this issue.

New middleware to catch any OptimadeWarnings Materials-Consortia/optimade-python-tools
1 participant
@CasperWA