-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaking up the python tools into seperable packages #255
Comments
I think the filter transformers should also be moved out of core as they're often using functionality from the backend to construct them (mongo is the exception). Apart from that, this proposed package structure looks reasonable to me. |
I agree about the transformers, it should probably be moved to Concerning the client, I think we should still hold on the fact that this should only be a repository for tools, i.e., we should avoid having an actual client in the repo. The adapter is a tool for a client (as I see it), so it's fine 😅 Other than those thoughts, I'm keen to start splitting this repo up in this way 👍 |
Hi, I would agree to move |
It might be a good time to add some extra folders like:
|
All makes sense. Give me till tomorrow afternoon and I'll have a PR for all of this. |
I would probably consider the |
Am I safe to close this? It seems we have decided to no split the package up for now due to the technical overhead, and I'm not sure there's anything left to discuss. Feel free to re-open if you disagree. |
The
optimade-python-tools
repo is now rather complex with several components. I suggest we break this up. One option is to make this into separate repos. Another is to make this into namespace packages, which I like lately. Namespace packages allow all of this to be developed in this repo, but deployed as independent packages.I'm suggesting the following packages:
optimade
: meta-package for alloptimade
subpackagesoptimade-core
:optimade.models
,optimade.grammar
,optimade.filterparser
,optimade.filtertransformers
optimade-server
:optimade.server
optimade-validator
:optimade.validator
optimade-client
:optimade.adapters
+ a future CLI or GUI?The text was updated successfully, but these errors were encountered: