Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PR SPECIFIC] Reminder: Validator test pinned to specific commit #268

Closed
shyamd opened this issue May 6, 2020 · 2 comments
Closed

[PR SPECIFIC] Reminder: Validator test pinned to specific commit #268

shyamd opened this issue May 6, 2020 · 2 comments
Labels
blocked For issues/PRs that are blocked by required changes/clarifications to the specification. CI Continuous Integration - GitHub Actions issues (NOT related to the repository Action) priority/high Issue or PR with a consensus of high priority validator Related to the OPTIMADE validator

Comments

@shyamd
Copy link
Contributor

shyamd commented May 6, 2020 •
edited by CasperWA
Loading

Make sure to switch the validator tests back to the SHA of the commit after the namespace packages are deployed (PR #264).
@shyamd shyamd changed the title Reminder: Reminder: Validator test pinned to specific commit May 6, 2020
@CasperWA CasperWA added the CI Continuous Integration - GitHub Actions issues (NOT related to the repository Action) label May 6, 2020
@CasperWA
Copy link
Member

CasperWA commented May 6, 2020 •
edited
Loading

.. and the optimade-validator-action has been subsequently updated to use the new namespace.

@CasperWA CasperWA added priority/high Issue or PR with a consensus of high priority validator Related to the OPTIMADE validator blocked For issues/PRs that are blocked by required changes/clarifications to the specification. labels May 6, 2020
@CasperWA CasperWA changed the title Reminder: Validator test pinned to specific commit [PR SPECIFIC] Reminder: Validator test pinned to specific commit Jun 5, 2020
@CasperWA
Copy link
Member

The PR #264 has been closed, this issue is no longer valid (please correct me and reopen with a new reference if needed @shyamd).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked For issues/PRs that are blocked by required changes/clarifications to the specification. CI Continuous Integration - GitHub Actions issues (NOT related to the repository Action) priority/high Issue or PR with a consensus of high priority validator Related to the OPTIMADE validator
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shyamd @CasperWA