Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return 553 for wrongly versioned base URLs #391

Closed
CasperWA opened this issue Jul 9, 2020 · 0 comments · Fixed by #420
Closed

Return 553 for wrongly versioned base URLs #391

CasperWA opened this issue Jul 9, 2020 · 0 comments · Fixed by #420
Assignees
@CasperWA
Labels
OpenAPI OpenAPI / Swagger related issue priority/high Issue or PR with a consensus of high priority server Issues pertaining to the example server implementation validator Related to the OPTIMADE validator

Comments

@CasperWA
Copy link
Member

CasperWA commented Jul 9, 2020

According to the v1.0.0 specification:

If a request is made to a versioned base URL that begins with /v and an integer followed by any other characters, indicating a version that the implementation does not recognize or support, the implementation SHOULD respond with the custom HTTP server error status code 553 Version Not Supported, preferably along with a user-friendly error message that directs the client to adapt the request to a version it provides.

We need to implement this both in the server, the OpenAPI schema, and in the validator.
@CasperWA CasperWA added OpenAPI OpenAPI / Swagger related issue priority/high Issue or PR with a consensus of high priority validator Related to the OPTIMADE validator server Issues pertaining to the example server implementation labels Jul 9, 2020
@CasperWA CasperWA changed the title Return 533 for wrongly versioned base URLs Return 553 for wrongly versioned base URLs Jul 9, 2020
@CasperWA CasperWA self-assigned this Jul 21, 2020
@CasperWA CasperWA mentioned this issue Jul 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CasperWA CasperWA

Labels
OpenAPI OpenAPI / Swagger related issue priority/high Issue or PR with a consensus of high priority server Issues pertaining to the example server implementation validator Related to the OPTIMADE validator
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement 553 Version Not Supported CasperWA/optimade-python-tools
1 participant
@CasperWA