-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3.9 support invalid #728
Comments
Why hasn't this been failing for other PRs? I thought I'd just broken something by adding config values |
No idea. But I don't want to waste time figuring it out. I'd rather just acknowledge that v1.6 of pydantic cannot be expected to support Python 3.9 and try instead to update our pydantic dependency. |
An idea: You can try to install the #660 branch in a Python 3.9 environment, updating to the latest pydantic version (1.8) and run pytest? |
I can confirm that everything passes |
Closed by updating to pydantic~=1.8 in #731. |
In #660 we have seen that using
pydantic
< 1.7 fails the Python 3.9 CI job - which it should, because Python 3.9 support was not added untilpydantic
v1.7 (see changelog).So official Python 3.9 support should be removed until we can support
pydantic
>= 1.7, which there is an open PR for: #715.The text was updated successfully, but these errors were encountered: