Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs builds are not properly tested for each PR #747

Closed
ml-evs opened this issue Mar 23, 2021 · 0 comments · Fixed by #748
Closed

Docs builds are not properly tested for each PR #747

ml-evs opened this issue Mar 23, 2021 · 0 comments · Fixed by #748
Assignees
@ml-evs
Labels
CI Continuous Integration - GitHub Actions issues (NOT related to the repository Action)

Comments

@ml-evs
Copy link
Member

ml-evs commented Mar 23, 2021

Currently on pull requests, only mkdocs build --strict is called by the CI. Really we should do the full invoke create-api-reference-docs -> mkdocs build to avoid any errors creeping in before release.
@ml-evs ml-evs added the CI Continuous Integration - GitHub Actions issues (NOT related to the repository Action) label Mar 23, 2021
@ml-evs ml-evs changed the title Docs are not tested for each PR Docs builds are not properly tested for each PR Mar 23, 2021
@ml-evs ml-evs self-assigned this Mar 23, 2021
@ml-evs ml-evs mentioned this issue Mar 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ml-evs ml-evs

Labels
CI Continuous Integration - GitHub Actions issues (NOT related to the repository Action)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Run full API docs invoke task for every PR Materials-Consortia/optimade-python-tools
1 participant
@ml-evs