Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double deaths are not detected #10

Open
Matsyir opened this issue May 5, 2020 · 0 comments
Open

Double deaths are not detected #10

Matsyir opened this issue May 5, 2020 · 0 comments
Labels
bug Something isn't working has known solution There is a known implementation method

Comments

@Matsyir
Copy link
Owner

Matsyir commented May 5, 2020

Related plugin component(s)
A fight's death detection.

Describe the bug
If a double death occurs, only a single death will be detected.

To reproduce
Steps to reproduce the behavior:

  1. Go to clan wars with a friend/alt
  2. Kill each other at the same time
  3. Observe that only the first death is saved.
    Of course, this can also be rarely tested from real fights.

Expected behavior
Both players are marked with a skull to indicate that they died. Perhaps an additional color/tooltip to signify who died first.

Additional context
This can be fixed by subscribing to the onPlayerDeath() event in the main plugin file, and managing deaths from there. It is a bit tricky, since currently fights are immediately ended when either player does the death animation. Some kind of timer/delay must be implemented to wait for a potential second death after the initial one.

@Matsyir Matsyir added bug Something isn't working has known solution There is a known implementation method labels May 5, 2020
@Matsyir Matsyir changed the title Double deaths are not counted if the players die at different times Double deaths are not detected Sep 29, 2020
@Matsyir Matsyir added the good first issue Good for newcomers label Mar 17, 2021
@Matsyir Matsyir removed the good first issue Good for newcomers label Apr 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working has known solution There is a known implementation method
Projects
None yet
Development

No branches or pull requests

1 participant