You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Related plugin component(s)
A fight's death detection.
Describe the bug
If a double death occurs, only a single death will be detected.
To reproduce
Steps to reproduce the behavior:
Go to clan wars with a friend/alt
Kill each other at the same time
Observe that only the first death is saved.
Of course, this can also be rarely tested from real fights.
Expected behavior
Both players are marked with a skull to indicate that they died. Perhaps an additional color/tooltip to signify who died first.
Additional context
This can be fixed by subscribing to the onPlayerDeath() event in the main plugin file, and managing deaths from there. It is a bit tricky, since currently fights are immediately ended when either player does the death animation. Some kind of timer/delay must be implemented to wait for a potential second death after the initial one.
The text was updated successfully, but these errors were encountered:
Related plugin component(s)
A fight's death detection.
Describe the bug
If a double death occurs, only a single death will be detected.
To reproduce
Steps to reproduce the behavior:
Of course, this can also be rarely tested from real fights.
Expected behavior
Both players are marked with a skull to indicate that they died. Perhaps an additional color/tooltip to signify who died first.
Additional context
This can be fixed by subscribing to the
onPlayerDeath()
event in the main plugin file, and managing deaths from there. It is a bit tricky, since currently fights are immediately ended when either player does the death animation. Some kind of timer/delay must be implemented to wait for a potential second death after the initial one.The text was updated successfully, but these errors were encountered: