From df1aae69ed48a6962843ca7b587ba554eaf5ebd9 Mon Sep 17 00:00:00 2001 From: Manuel Giffels Date: Mon, 15 Apr 2024 18:08:52 +0200 Subject: [PATCH 1/2] Fix hash credentials test for new typer version --- CONTRIBUTORS | 2 ++ docs/source/changelog.rst | 4 ++-- tests/rest_t/hash_credentials_t/test_hash_credentials.py | 2 +- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/CONTRIBUTORS b/CONTRIBUTORS index 73e5bb00..c90d2d94 100644 --- a/CONTRIBUTORS +++ b/CONTRIBUTORS @@ -11,7 +11,9 @@ Rene Caspart Leon Schuhmacher R. Florian von Cube Benjamin Rottler +Sebastian Wozniewski mschnepf +swozniewski Alexander Haas <104835302+haasal@users.noreply.github.com> mschnepf Dirk Sammel diff --git a/docs/source/changelog.rst b/docs/source/changelog.rst index 4da36d0a..4172b7cc 100644 --- a/docs/source/changelog.rst +++ b/docs/source/changelog.rst @@ -1,4 +1,4 @@ -.. Created by changelog.py at 2024-02-05, command +.. Created by changelog.py at 2024-04-15, command '/Users/giffler/.cache/pre-commit/repoecmh3ah8/py_env-python3.12/bin/changelog docs/source/changes compile --categories Added Changed Fixed Security Deprecated --output=docs/source/changelog.rst' based on the format of 'https://keepachangelog.com/' @@ -6,7 +6,7 @@ CHANGELOG ######### -[Unreleased] - 2024-02-05 +[Unreleased] - 2024-04-15 ========================= Fixed diff --git a/tests/rest_t/hash_credentials_t/test_hash_credentials.py b/tests/rest_t/hash_credentials_t/test_hash_credentials.py index 1da9126e..3adc7858 100644 --- a/tests/rest_t/hash_credentials_t/test_hash_credentials.py +++ b/tests/rest_t/hash_credentials_t/test_hash_credentials.py @@ -15,7 +15,7 @@ def setUp(self) -> None: def test_hash_credentials(self): result = self.runner.invoke(self.app) self.assertNotEqual(result.exit_code, 0) - self.assertTrue("Error: Missing argument 'PASSWORD'." in result.stdout) + self.assertTrue("Missing argument 'PASSWORD'." in result.stdout) result = self.runner.invoke(self.app, "test_password") self.assertEqual(result.exit_code, 0) From 39fc5cd6548a12bd7059cc13a4d817eb32a198d0 Mon Sep 17 00:00:00 2001 From: Manuel Giffels Date: Tue, 16 Apr 2024 09:29:31 +0200 Subject: [PATCH 2/2] Aaply suggestion by github advance security --- docs/source/changelog.rst | 4 ++-- tests/rest_t/hash_credentials_t/test_hash_credentials.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/source/changelog.rst b/docs/source/changelog.rst index 4172b7cc..6801374e 100644 --- a/docs/source/changelog.rst +++ b/docs/source/changelog.rst @@ -1,4 +1,4 @@ -.. Created by changelog.py at 2024-04-15, command +.. Created by changelog.py at 2024-04-16, command '/Users/giffler/.cache/pre-commit/repoecmh3ah8/py_env-python3.12/bin/changelog docs/source/changes compile --categories Added Changed Fixed Security Deprecated --output=docs/source/changelog.rst' based on the format of 'https://keepachangelog.com/' @@ -6,7 +6,7 @@ CHANGELOG ######### -[Unreleased] - 2024-04-15 +[Unreleased] - 2024-04-16 ========================= Fixed diff --git a/tests/rest_t/hash_credentials_t/test_hash_credentials.py b/tests/rest_t/hash_credentials_t/test_hash_credentials.py index 3adc7858..9e193a94 100644 --- a/tests/rest_t/hash_credentials_t/test_hash_credentials.py +++ b/tests/rest_t/hash_credentials_t/test_hash_credentials.py @@ -15,7 +15,7 @@ def setUp(self) -> None: def test_hash_credentials(self): result = self.runner.invoke(self.app) self.assertNotEqual(result.exit_code, 0) - self.assertTrue("Missing argument 'PASSWORD'." in result.stdout) + self.assertIn("Missing argument 'PASSWORD'.", result.stdout) result = self.runner.invoke(self.app, "test_password") self.assertEqual(result.exit_code, 0)