-
-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warning: findDOMNode is deprecated outside StrictMode. #706
Comments
Hey, thanks for raising this. I saw the patch notes the other day and was like, whelp, that's going to be a fun one 😄 |
@MatthewHerbst @yusuf-saydullayev any update on this ? |
Currently working on v3 of this library which will introduce some long needed breaking changes that will also allow supporting React 19 properly. I expect to have a beta release out by the end of the weekend |
Removing |
Has the beta been released somewhere? I apologize if you're still working on it, just trying to make sure I'm not crazy for not seeing it anywhere since you wrote this 2 weeks ago. |
You're not crazy, I'm still fighting with it unfortunately, it's a pretty core change to how this library operates. Looking forward to the long weekend to get this over the finish line, at least with some sort of v3-alpha release |
Update: I went down a rabbit hole trying to also get an ESM build out finally as part of v3. I think I'm going to give that up for now and just push the fix for React 19, targeting getting a release out this evening unless I run into some other issue. Will keep y'all updated. It's just me on this project, so I appreciate everyone's patience |
Your efforts are appreciated @MatthewHerbst |
react-draggable has an alternative to findDOMnode by using the ref, maybe that could help? |
Alright friends, the day has arrived! Please give |
Thank you @MatthewHerbst 🎉 |
Going to let v3 beta bake for the rest of the week. If all is well after that I'll promote this out of beta this coming weekend |
Awesome! |
Any progress on making these changes official? |
Ah, apologies, work has had me slammed and I haven't had time to look at this for a bit. I haven't had any more reports of issues with the beta so I will get it published as v3.0.0 before the weekend ends. Thanks for reminding me! |
Thank you! |
|
Hi, Has any updates to remove findDOMNode. In react 18.3 adds warnings for deprecate this API and in v19 will be removed.
thanks.
Prev related issue: #282
The text was updated successfully, but these errors were encountered: