Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In 3.0.3 and later onAfterPrint is called only after clicking back on the page #779

Closed
sergey-hippo opened this issue Jan 3, 2025 · 12 comments · Fixed by #780
Closed

In 3.0.3 and later onAfterPrint is called only after clicking back on the page #779

sergey-hippo opened this issue Jan 3, 2025 · 12 comments · Fixed by #780

Comments

@sergey-hippo
Copy link

When using version 3.0.3 or 3.0.4, onAfterPrint is called only after clicking back on the page after print dialogue is closed.
This behavior is not present in 3.0.2

@MatthewHerbst
Copy link
Owner

Ah, I was afraid something like this might happen. This is likely caused by #764. Could you please let me know what browser you are using? The browsers I tested restored focus to the page automatically after closing the dialog, but I was afraid some might not.

@sergey-hippo
Copy link
Author

I'm using Vivaldi 6.8.3381.48 on macOS Version 15.2 and the issue is 100% reproducible for me.

@MatthewHerbst
Copy link
Owner

I will try to get a fix out this evening. I'll either find a way to combine the original solution with #764, or I'll revert #764

@sensasi-delight
Copy link
Contributor

Hi, I just wanted to confirm that I can reproduce this issue on Vivaldi v6 and v7, as well as Chrome and Edge v131 on my Windows 11 setup. I'll be submitting a PR shortly to address this issue while ensuring compatibility with the solution for issue #187.

@Bowbaq
Copy link

Bowbaq commented Jan 22, 2025

FWIW we also ran into this bug, and reverting to 3.0.2 fixed it for us

@MatthewHerbst
Copy link
Owner

Thanks for the report @Bowbaq and apologies all for my tardiness here, I will look at getting the fix merged in today or tomorrow.

@MatthewHerbst
Copy link
Owner

@Bowbaq what browser were you using? Also Vivaldi?

@MatthewHerbst
Copy link
Owner

Also as a heads up, not sure how to link to it, but with Vivaldi specifically, this issue is being tracked as VB-112980

@Bowbaq
Copy link

Bowbaq commented Jan 25, 2025

I was able to reproduce the issue on Arc (which is chrome-based) and the user that reported the issue to me also uses Chrome.

@MatthewHerbst
Copy link
Owner

Thanks for letting us know!

@zetoke
Copy link

zetoke commented Jan 27, 2025

@MatthewHerbst yeah, it seems to be true for Chrome too (or a Chrome based browser). And also saw the issue with Firefox as well for a user.

@MatthewHerbst
Copy link
Owner

@sensasi-delight's fix has been published as version v3.0.5. Thank you all for the reports and your patience. Please let me know if you encounter further issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants