Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub changelog link anchors no longer found #162

Closed
mattmenefee opened this issue Jul 26, 2023 · 3 comments
Closed

GitHub changelog link anchors no longer found #162

mattmenefee opened this issue Jul 26, 2023 · 3 comments

Comments

@mattmenefee
Copy link
Contributor

It appears that the format of GitHub's Changelog has changed slightly such that this line no longer works. I believe it's due to GitHub escaping the word "anchor" when specifying the CSS class on the a tag in more recent versions of its Markdown processor. In my local testing, I found that replacing:

changelog_page.css(%(a.anchor))

with something like this using an XPATH selector:

changelog_page.css(%(//a[contains(@class, "anchor")]))

seemed to have fixed the issue. You may need to update your VCR cassette in order to get a failing test.

@mattmenefee
Copy link
Contributor Author

Fixed by #163

@mattmenefee
Copy link
Contributor Author

@MaximeD thanks for the fix!

@MaximeD
Copy link
Owner

MaximeD commented Jul 27, 2023

Thank you for reporting it, along with a way to fix it!
Version 6.0.2 has been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants