Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arm C Compiler doesn't support gmtime() #1975

Closed
simonbutcher opened this issue Aug 22, 2018 · 2 comments
Closed

Arm C Compiler doesn't support gmtime() #1975

simonbutcher opened this issue Aug 22, 2018 · 2 comments
Labels

Comments

@simonbutcher
Copy link
Contributor

Description

  • Type: Bug
  • Priority: Major

Bug

OS
Mbed OS


The Arm C Compiler does not support gmtime() as stated in the documentation. Yet, Mbed TLS will build with it, but calls to gmtime() will return a NULL - therefore MBEDTLS_HAVE_TIME can't work with ARM C Compiler.

We probably need a check in check_config.h to detect the ARM C Compiler and to issue an error if MBEDTLS_HAVE_TIME is enabled.

@ciarmcom
Copy link

ARM Internal Ref: IOTSSL-2486

@simonbutcher
Copy link
Contributor Author

If a compiler or platform (such as the Arm C Compiler) doesn't provide gmtime() or gmtime_r(), we now allow users integrating the library to provide their own implementation of either by implementing the function mbedtls_platform_gmtime_r() which is an abstraction of gmtime_r(). This feature was introduced in PR #1927.

Therefore it doesn't matter if gmtime() isn't supported on any given platform - but it is however the responsibility of those integrating Mbed TLS with the platform to provide their own implementation.

And to be clear - the Mbed TLS project has no plans to provide it's own implementation of gmtime() or gmtime_r().

Therefore this issue can now be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants