Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PSA: forced bits in Montgomery private keys #3399

Closed
gilles-peskine-arm opened this issue Jun 4, 2020 · 2 comments
Closed

PSA: forced bits in Montgomery private keys #3399

gilles-peskine-arm opened this issue Jun 4, 2020 · 2 comments
Labels
component-crypto Crypto primitives and low-level interfaces enhancement good-first-issue Good for newcomers

Comments

@gilles-peskine-arm
Copy link
Contributor

An upcoming revision of the PSA Crypto specification will clarify that the export format of Curve25519 and Curve448 private keys must have the forced bits set as specificed in RFC 7748 §5 (output of decodeScalar25519 and decodeScalar448).

Goal of this task:

  • Update the documentation of psa_export_key in crypto.h.
  • Add tests to validate that if you import a Curve25519 or Curve448 private key where the forced bits are incorrect, either the key is rejected, or the forced bits will be set on export.
  • Add tests to validate that the forced bits are correct in generated keys.
@gilles-peskine-arm gilles-peskine-arm added enhancement component-crypto Crypto primitives and low-level interfaces PSA compliance good-first-issue Good for newcomers labels Jun 4, 2020
@stevew817 stevew817 mentioned this issue Jun 11, 2020
Merged
3 tasks
@gilles-peskine-arm
Copy link
Contributor Author

#3425 addresses Curve25519. The Curve448 part is still pending.

@silabs-ArchanaM silabs-ArchanaM mentioned this issue Jun 8, 2021
Merged
2 tasks
@gilles-peskine-arm
Copy link
Contributor Author

This was done in #4626.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component-crypto Crypto primitives and low-level interfaces enhancement good-first-issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gilles-peskine-arm