Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MBEDTLS_AES_SETKEY_DEC_ALT excludes MBEDTLS_CIPHER_MODE_XTS methods #3818

Closed
stroebeljc opened this issue Oct 23, 2020 · 0 comments · Fixed by #3823 or #3863
Closed

MBEDTLS_AES_SETKEY_DEC_ALT excludes MBEDTLS_CIPHER_MODE_XTS methods #3818

stroebeljc opened this issue Oct 23, 2020 · 0 comments · Fixed by #3823 or #3863
Assignees
@gabor-mezei-arm
Labels
bug component-crypto Crypto primitives and low-level interfaces

Comments

@stroebeljc
Copy link
Contributor

I had an issue building with MBEDTLS_AES_SETKEY_DEC_ALT because key methods in MBEDTLS_CIPHER_MODE_XTS were excluded from the build, yet they are still needed. I am unclear why this dependency exists and feel that the #endif should be moved before the MBEDTLS_CIPHER_MODE_XTS code block.
https://github.com/ARMmbed/mbedtls/blob/da9f92c2b2c38c7add6c088ca9b31bef6586b7b4/library/aes.c#L811
@gabor-mezei-arm gabor-mezei-arm self-assigned this Oct 26, 2020
@gabor-mezei-arm gabor-mezei-arm mentioned this issue Oct 26, 2020
Merged
1 task
@gabor-mezei-arm gabor-mezei-arm added the component-crypto Crypto primitives and low-level interfaces label Oct 26, 2020
@gabor-mezei-arm gabor-mezei-arm mentioned this issue Nov 6, 2020
Merged
@gabor-mezei-arm gabor-mezei-arm linked a pull request Nov 6, 2020 that will close this issue
[Backport 2.16] Make the aes xts methods independent from MBEDTLS_AES_SETKEY_DEC_ALT #3863
Merged
@yanesca yanesca mentioned this issue Feb 1, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gabor-mezei-arm gabor-mezei-arm

Labels
bug component-crypto Crypto primitives and low-level interfaces
Projects
None yet
Milestone
No milestone
2 participants
@stroebeljc @gabor-mezei-arm