Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support critical extensions for certificate signing requests #4055

Closed
creiter32 opened this issue Jan 21, 2021 · 0 comments · Fixed by #4568
Closed

Support critical extensions for certificate signing requests #4055

creiter32 opened this issue Jan 21, 2021 · 0 comments · Fixed by #4568
Labels
component-x509 enhancement good-first-issue Good for newcomers

Comments

@creiter32
Copy link
Contributor

Description

  • Type: Enhancement
  • Priority: Minor

Extensions for X.509 certificate signing requests (CSR) can be marked as critical but mbedtls currently doesn't expose this functionality through it's API: https://github.com/ARMmbed/mbedtls/blob/development/include/mbedtls/x509_csr.h#L241 even though the underlying function exposes a flag for this purpose: https://github.com/ARMmbed/mbedtls/blob/development/library/x509write_csr.c#L88

Enhancement

Justification - why does the library need this feature?

Some use cases for X.509 certificate signing requests need extensions that are marked as critical and the effort to implement this is minor.

Suggested enhancement

Expose the critical flag through the API by forwarding the parameter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component-x509 enhancement good-first-issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Expose flag for critical extensions creiter32/mbedtls
2 participants
@creiter32 @tom-daubney-arm