Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated function mbedtls_ssl_conf_curves() #9891

Open
mpg opened this issue Jan 10, 2025 · 0 comments · May be fixed by #9906
Open

Remove deprecated function mbedtls_ssl_conf_curves() #9891

mpg opened this issue Jan 10, 2025 · 0 comments · May be fixed by #9906
Assignees
Labels
api-break This issue/PR breaks the API and must wait for a new major version component-tls size-s Estimated task size: small (~2d)

Comments

@mpg
Copy link
Contributor

mpg commented Jan 10, 2025

The function mbedtls_ssl_conf_curves() has been deprecated in favour of mbedtls_ssl_conf_groups(). One reason it is problematic is because it use mbedtls_ecp_group_id from ecp.h which is going to become private in 1.0/4.0.

This task is to:

  • Remove mbedtls_ssl_conf_curves() (declaration and implementation).
  • Remove test cases that are specifically about it (the test function conf_curve() in test_suite_ssl can be fully removed). Remove mentions of these tests in analyze_outcomes.py as well.
  • I think all test code that's not specifically about it have been migrated to conf_group() already. Double-check and if necessary migrate any leftovers to conf_group().
  • Remove mentions of this function from documentation. At this point git grep mbedtls_ssl_conf_curves should only find occurrences in the ChangeLog.
  • Add a ChangeLog entry saying this deprecated function was removed and people should use conf_groups instead.
  • Remove field curve_list from mbedtls_ssl_config and all places in the code that used it. Normally they should all be guarded with ECP_C && !DEPRECATED_REMOVED already.

This task is development-only.

@mpg mpg added enhancement api-break This issue/PR breaks the API and must wait for a new major version size-s Estimated task size: small (~2d) labels Jan 10, 2025
@mpg mpg moved this to Remove legacy types from public non-PSA interfaces in Mbed TLS Epics Jan 10, 2025
@mpg mpg moved this to Implementation needed in Mbed TLS 4.0 planning Jan 10, 2025
@mpg mpg mentioned this issue Jan 10, 2025
11 tasks
@mpg mpg self-assigned this Jan 14, 2025
@mpg mpg linked a pull request Jan 14, 2025 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-break This issue/PR breaks the API and must wait for a new major version component-tls size-s Estimated task size: small (~2d)
Projects
Status: Implementation needed
Status: Remove legacy types from public non-PSA interfaces
Development

Successfully merging a pull request may close this issue.

1 participant