-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hubspot 'main' PR #10
Conversation
DATA-3418 Added property streams
DATA-3419 Added association type stream
DATA-3550 Removed unused code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey folks!
Can you sync the poetry.lock
file? That'll save some time not resolving dependencies in CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't wanna leave a comment for each stream class 😅, but I think we can replace parse_response
with records_jsonpath
.
DATA-3651 Added records jsonpath
Hey @edgarrmondragon, we have removed the parse_response function in favor of records_jsonpath, and have also added the Poetry.lock file in repo so tests finish quickly. |
Thanks for your patience @NeilGorman104, this LGTM! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hubspot main PR:
Update: We have added the following ‘objects’ streams which previously were covered only in the properties stream:
Note: Pytests are not passing for the following reasons:
AssertionError: No records returned in stream
for each of the streams where we have no data in our Hubspot test account