Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking out host,user,port into different configuration values #5

Open
visch opened this issue Nov 11, 2022 · 1 comment
Open

Breaking out host,user,port into different configuration values #5

visch opened this issue Nov 11, 2022 · 1 comment

Comments

@visch
Copy link
Member

visch commented Nov 11, 2022

This allows for a lot more customization much easier for use with things like CI pipelines than using / constructing the sqlalchemy_url
@qbatten qbatten mentioned this issue Jan 26, 2023
Closed
@qbatten
Copy link
Contributor

qbatten commented Jan 30, 2023 •
edited
Loading

Per @aaronsteers comment here, should we drop the sqlalchemy_url option altogether? @visch what do you think about that? Seems like the pro/con of allowing users to pass sqlalchemy_url is something like:

Pro: Flexible for users
Con: Leaves the tap with less control; could cause things to break if the tap upgrades driver and a user isn't aware of that

Sounds like either way we'll exclude the dialect+driver option in the broken-out configuration.

@qbatten qbatten mentioned this issue Feb 7, 2023
Closed
@pnadolny13 pnadolny13 mentioned this issue Apr 18, 2023
Merged
@visch visch mentioned this issue May 1, 2023
Merged
1 task
visch added a commit that referenced this issue Jun 23, 2023
@visch @edgarrmondragon @pnadolny13
feat: Break out host, user, port, etc. into individual config v…
4482e4e 
…alues (#121)

Closes #30, #5

- [x] Need to implement SSL as a configuration option as well (Going to
do separately see #117
)

---------

Co-authored-by: Edgar R. M <[email protected]>
Co-authored-by: Pat Nadolny <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: break out conn str, stream map options, precommit, linting multimediallc/tap-postgres
2 participants
@visch @qbatten