chore: Standardise on queryAll operation in Bulk API 2.0 implementation #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maamoonhussain
changed the title
edgarrmondragon
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the Bulk API 2.0 implementation uses
queryoperation while both REST API and Bulk API 1.0 usequeryAll. This inconsistency means that Bulk API 2.0 might miss deleted and archived records that are captured by the other API types.Current Behavior
queryAllqueryAllqueryExpected Behavior
All API types should use
queryAllto ensure consistent behavior and data completeness across different API implementations.Technical Details
The change required is in
tap_salesforce/salesforce/bulk2.py, updating the operation from "query" to "queryAll" in the_create_jobmethod.References
Impact
This change will ensure that Bulk API 2.0 returns the same set of records as the other API types, including deleted and archived records.
Type