Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup logic for clickable/selectable listItem elements #562

Open
MeoMix opened this issue May 21, 2015 · 0 comments
Open

Cleanup logic for clickable/selectable listItem elements #562

MeoMix opened this issue May 21, 2015 · 0 comments

Comments

@MeoMix
Copy link
Owner

MeoMix commented May 21, 2015

Currently there's a lot of weirdness going on in the CSS surrounding clickable/selectable elements.

This horrible selector exists because I thought all listItem's would want a :hover effect. It turns out that's not actually the case (or maybe those things shouldn't be considered listItems, I don't know.)

Regardless, this isn't working and it needs to be broken down and reworked.

&:not(.is-disabled):not(.grouping-item):not(.simpleListItem):hover {
    background: @dark--quinary;
}

Similarly, I've got this clickable class:

.listItem--clickable {
    cursor: pointer;
}

because I thought all list items would want to be clickable, but that's not always true, either. Sometimes I'm just presenting information in a nice way, but there's no other options available in the list item so no click effect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant