Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing/incorrect propTypes on geppetto-showcase #285

Open
6 tasks
Muhaddatha opened this issue Feb 8, 2022 · 1 comment
Open
6 tasks

Fix missing/incorrect propTypes on geppetto-showcase #285

Muhaddatha opened this issue Feb 8, 2022 · 1 comment
Labels
bug Something isn't working geppetto-showcase good first issue Good for newcomers

Comments

@Muhaddatha
Copy link
Contributor

Muhaddatha commented Feb 8, 2022

After the work done on #246.
We realized a couple of new issues related with the showing of propTypes which require further investigation.

For example, the PlotComponent has the following props:

But the prop list looks like this in the showcase: image.png

Fields such as PlotComponent.plots.x and PlotComponent.plots.lineOptions are not displayed in the showcase.

Checklist:

  • Add type and description to connectivity viewer > names > name attribute:
  • Add type and description to VR canvas > instances > name attribute
  • Fix incorrect props for connectivity viewer > layout
  • Fix incorrect props for dicom-viewer
  • Fix incorrect props for plotcomponent > plots
  • Fix incorrect props for list viewer > columnConfiguration
@Muhaddatha Muhaddatha added geppetto-showcase bug Something isn't working labels Feb 8, 2022
@Muhaddatha Muhaddatha changed the title Some UI elements props fields don't show up in the showcase Some PlotComponent prop fields don't show up in the showcase Feb 8, 2022
@enicolasgomez enicolasgomez added the good first issue Good for newcomers label Feb 8, 2022
@afonsobspinto afonsobspinto changed the title Some PlotComponent prop fields don't show up in the showcase Fix missing/incorrect propTypes on geppetto-showcase Feb 8, 2022
@afonsobspinto
Copy link
Member

For the incorrect props, It seems that we are retrieving the props correctly from the code:
image
So my best guest is that the problem will be in the way we generate the table aka here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working geppetto-showcase good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants