Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please use rdfs label for the display label in Composer #235

Closed
stappan opened this issue Feb 20, 2024 · 2 comments
Closed

Please use rdfs label for the display label in Composer #235

stappan opened this issue Feb 20, 2024 · 2 comments

Comments

@stappan
Copy link
Collaborator

stappan commented Feb 20, 2024

There's many synonyms for terms in the ontologies, please select the rdfs label to display, as that is the preferred label.
AMB should be Nucleus Ambiguus
image

@stappan
Copy link
Collaborator Author

stappan commented Feb 21, 2024

The 'o_label' column represents the rdfs:label and 'o_synonym' contains the possible synonyms in the sheet that Fahim shared. Can you look at your internal data structures and see how you're distinguishing the labels (i.e., the preferred name of the structure) from synonyms. When showing the labels in the diagram or for the locations of the neuronal parts, use the label. When searching for the terms, they should allow both synonyms and labels.

@stappan
Copy link
Collaborator Author

stappan commented Feb 22, 2024

In talking about this with Fahim, the question arose:

How we should specify the requirement for picking up a synonym i.e., if someone picks a synonym of a term during the knowledge construction phase, should we display the synonym in the diagram as well? I think we need to specify the policy on this.

Ideally, we should always have the preferred label (the rdfs:label from UBERON or ILX) for both cases. So, when someone picks Amb as the origin from the autocomplete list for instance, Composer should get the rdfs:label for that class which is 'nucleus ambiguus', and have an automated note for the user that reflects the fact that Amb is a synonym for the preferred label of the term 'nucleus amiguus' and that the knowledge statement will use that preferred label instead of Amb.

Potential Acceptance criteria #1:
Across search (path builder, sentence, anatomical entity search in the admin interface, etc), preferred and synonym labels for anatomical entities will display. When an entity is selected, the rdfs:label, regardless of synonym choice, will be utilized in knowledge statements and diagrams.

Potential Reason why this might not work: In rat, the inferior hypogastric ganglion is known as the pelvic ganglion. Ilias has indicated that he thinks the distinction is relevant for display purposes. Should confirm/discuss with him (& Maryann) prior to acceptance criteria being drafted, accepted and implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants