-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please use rdfs label for the display label in Composer #235
Comments
The 'o_label' column represents the rdfs:label and 'o_synonym' contains the possible synonyms in the sheet that Fahim shared. Can you look at your internal data structures and see how you're distinguishing the labels (i.e., the preferred name of the structure) from synonyms. When showing the labels in the diagram or for the locations of the neuronal parts, use the label. When searching for the terms, they should allow both synonyms and labels. |
In talking about this with Fahim, the question arose: How we should specify the requirement for picking up a synonym i.e., if someone picks a synonym of a term during the knowledge construction phase, should we display the synonym in the diagram as well? I think we need to specify the policy on this. Ideally, we should always have the preferred label (the rdfs:label from UBERON or ILX) for both cases. So, when someone picks Amb as the origin from the autocomplete list for instance, Composer should get the rdfs:label for that class which is 'nucleus ambiguus', and have an automated note for the user that reflects the fact that Amb is a synonym for the preferred label of the term 'nucleus amiguus' and that the knowledge statement will use that preferred label instead of Amb. Potential Acceptance criteria #1: Potential Reason why this might not work: In rat, the inferior hypogastric ganglion is known as the pelvic ganglion. Ilias has indicated that he thinks the distinction is relevant for display purposes. Should confirm/discuss with him (& Maryann) prior to acceptance criteria being drafted, accepted and implemented. |
There's many synonyms for terms in the ontologies, please select the rdfs label to display, as that is the preferred label.
![image](https://private-user-images.githubusercontent.com/106172226/306434913-6b3fa190-9331-48b4-a2ad-c4e6409b6f59.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzMTg1NzEsIm5iZiI6MTczOTMxODI3MSwicGF0aCI6Ii8xMDYxNzIyMjYvMzA2NDM0OTEzLTZiM2ZhMTkwLTkzMzEtNDhiNC1hMmFkLWM0ZTY0MDliNmY1OS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjExJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxMVQyMzU3NTFaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT03YjI4NTRmNGY3OGRlN2UwYzRhMGQwNmVmNGNiZTM4NGViZThlZTM5OGM2MDU5ZDFjNmQ2ZGZhMjc1ZmZlOTVlJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.jQz5dFfQE8BU6PxyWvLPuFDo6x_xgRu3R7KrDlv0efk)
AMB should be Nucleus Ambiguus
The text was updated successfully, but these errors were encountered: