Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify neurondm ingestion to populate the layer table and store intersections layer+region #243

Closed
ddelpiano opened this issue Mar 6, 2024 · 2 comments

Comments

@ddelpiano
Copy link
Member

When performing the neurondm ingestion we will need to ensure that the following is performed:

  • when encountering a layer in the partial order tuple, check if the layer already exists in the layer table, if not check if this exists in the AE table and if yes copy this to the layer table (attention, we are keeping the layer in the AE table, we are just copying it in the layer table).
  • If the layer does not exists in the layer table and also in the AE table, then raise an error and set the KS invalid (brief explanation why, the partial order only provides us with the layer URI, if this is missing in the AE table we don't know what label this layer should have, this will required manual curation from the admin to add the layer manually in the system, add the intersection manually and then curate this KS again).

Acceptance criteria:

  • when running the ingestion, if a new layer is found this should be added to the layer table
  • when running the ingestion, if a new intersection layer+region is found this should be added to the intersection table
  • when visualising the proofing tab of a KS that contains an intersection, this should be visible from the path builder label used
@stappan
Copy link
Collaborator

stappan commented Mar 8, 2024

As a reminder, layers are not required, so if there are only regions, they should be ingested without error

@ddelpiano
Copy link
Member Author

As a reminder, layers are not required, so if there are only regions, they should be ingested without error

Sure 👍🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants