Skip to content
This repository has been archived by the owner on May 12, 2022. It is now read-only.

Action Screens for Fishing Attacks #18

Closed
cjeria opened this issue May 25, 2018 · 2 comments
Closed

Action Screens for Fishing Attacks #18

cjeria opened this issue May 25, 2018 · 2 comments
Assignees
@cjeria
Labels
Permissions / Pop-ups Related to user permissions and dapp-wallet actions

Comments

@cjeria
Copy link
Contributor

cjeria commented May 25, 2018

User story and sketches from Mural session
https://app.mural.co/t/consensys3989/m/consensys3989/1527187224674/c1ede03935b891c510322112e456029556233e22

b82850be-8b58-4462-8e30-c5c2e2419a2e
@cjeria cjeria added the Permissions / Pop-ups Related to user permissions and dapp-wallet actions label May 25, 2018
This was referenced Jun 4, 2018
Closed
Closed
@cjeria cjeria self-assigned this Jun 4, 2018
@danjm danjm mentioned this issue Jun 4, 2018
Closed
@bdresser
Copy link

bdresser commented Jun 5, 2018 •
edited
Loading

we can extend the designs in #11 to help indicate what's happening here - specifically when a user is asked to call an approve() function.

perhaps with a more detailed special-case header, or with a small line of text that describes what's happening ("you're approving 0xe9d to spend up to 300 of your OMG at any time").

can also add a support article & "Learn more" link

This was referenced Jun 5, 2018
Closed
Closed
@bdresser
Copy link

We've shipped a custom template for approve calls and are now showing known function names.

Other improvements are covered by #38 and MetaMask/metamask-extension#5087

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cjeria cjeria

Labels
Permissions / Pop-ups Related to user permissions and dapp-wallet actions
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cjeria @bdresser