From 7d35df0cee5b7390d7b87b33ddec681828b6ba3a Mon Sep 17 00:00:00 2001 From: Elliot Winkler Date: Tue, 31 Oct 2023 17:05:58 -0600 Subject: [PATCH 1/5] Bump min Node to 16, and use LTS Node for dev **This change is breaking.** We could bump this monorepo to Node 18, but since these packages are heavily depended upon, we don't need to do that yet until we've confirmed all other projects are using 18. Using the LTS version of Node puts us on a more modern version for development (and also happens to fix the `.nvmrc` file so `asdf` can read it). --- .nvmrc | 2 +- package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.nvmrc b/.nvmrc index 958b5a36..b009dfb9 100644 --- a/.nvmrc +++ b/.nvmrc @@ -1 +1 @@ -v14 +lts/* diff --git a/package.json b/package.json index f23f41be..b3a76887 100644 --- a/package.json +++ b/package.json @@ -43,7 +43,7 @@ }, "packageManager": "yarn@3.2.4", "engines": { - "node": ">=14.0.0" + "node": ">=16.0.0" }, "lavamoat": { "allowScripts": { From 2d297a7848860cd7b3bb09f99bf23825ff8bf248 Mon Sep 17 00:00:00 2001 From: Elliot Winkler Date: Tue, 31 Oct 2023 17:14:35 -0600 Subject: [PATCH 2/5] Update README --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 80f5db53..a8e0a1c7 100644 --- a/README.md +++ b/README.md @@ -8,8 +8,8 @@ correctly specify their peer dependencies. ### Setup -- Install [Node.js](https://nodejs.org) version 14 - - If you are using [nvm](https://github.com/creationix/nvm#installation) (recommended) running `nvm use` will automatically choose the right node version for you. +- Install the current LTS version of [Node.js](https://nodejs.org) + - If you are using [nvm](https://github.com/creationix/nvm#installation) (recommended) running `nvm install` will install the latest version and running `nvm use` will automatically choose the right node version for you. - Install [Yarn v3](https://yarnpkg.com/getting-started/install) - Run `yarn install` to install dependencies and run any required post-install scripts From 653adbea104d1732ac78b3df1718e010eefc2774 Mon Sep 17 00:00:00 2001 From: Elliot Winkler Date: Wed, 22 Nov 2023 14:16:46 -0700 Subject: [PATCH 3/5] Bump Node to 18 --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index b3a76887..4076e84b 100644 --- a/package.json +++ b/package.json @@ -43,7 +43,7 @@ }, "packageManager": "yarn@3.2.4", "engines": { - "node": ">=16.0.0" + "node": "^18.18 || >=20" }, "lavamoat": { "allowScripts": { From 7100c2679dde1d7e74268dd122a4b4f04b97ac04 Mon Sep 17 00:00:00 2001 From: legobt <6wbvkn0j@anonaddy.me> Date: Thu, 30 Nov 2023 02:27:53 +0000 Subject: [PATCH 4/5] add back support for node 16.20 --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 4076e84b..79c9e2df 100644 --- a/package.json +++ b/package.json @@ -43,7 +43,7 @@ }, "packageManager": "yarn@3.2.4", "engines": { - "node": "^18.18 || >=20" + "node": "^16.20 || ^18.18 || >=20" }, "lavamoat": { "allowScripts": { From d94f81053d293404953b8012a1fac7231a9400ac Mon Sep 17 00:00:00 2001 From: legobt <6wbvkn0j@anonaddy.me> Date: Thu, 30 Nov 2023 02:31:35 +0000 Subject: [PATCH 5/5] ci: run lint-test on node.js v20 instead of v14,v19 --- .github/workflows/lint-test.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/lint-test.yml b/.github/workflows/lint-test.yml index ed9a94c0..ffac91ac 100644 --- a/.github/workflows/lint-test.yml +++ b/.github/workflows/lint-test.yml @@ -26,7 +26,7 @@ jobs: - prepare strategy: matrix: - node-version: [14.x, 16.x, 18.x, 19.x] + node-version: [16.x, 18.x, 20.x] steps: - uses: actions/checkout@v3 - name: Use Node.js ${{ matrix.node-version }} @@ -57,7 +57,7 @@ jobs: - prepare strategy: matrix: - node-version: [14.x, 16.x, 18.x, 19.x] + node-version: [16.x, 18.x, 20.x] steps: - uses: actions/checkout@v3 - name: Use Node.js ${{ matrix.node-version }}