Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typing of error data and stack properties #34

Merged
merged 2 commits into from
Nov 17, 2020
Merged

Fix typing of error data and stack properties #34

merged 2 commits into from
Nov 17, 2020

Conversation

rekmarks
Copy link
Member

@rekmarks rekmarks commented Nov 17, 2020 •
edited
Loading

If stack is present, it will be a string. This PR updates the SerializedEthereumRpcError interface to reflect this. Also fixes a couple of minor docstring / type errors.

@rekmarks rekmarks requested a review from a team as a code owner November 17, 2020 01:00
@rekmarks rekmarks changed the title Fix serialized error stack property Fix serialized error interface stack property Nov 17, 2020
brad-decker
brad-decker approved these changes Nov 17, 2020
View reviewed changes
Copy link

@brad-decker brad-decker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rekmarks rekmarks changed the title Fix serialized error interface stack property Fix typing of error data and stack properties Nov 17, 2020
@rekmarks
Copy link
Member Author

CI is passing: https://app.circleci.com/pipelines/github/MetaMask/eth-rpc-errors?branch=type-fixup

@rekmarks rekmarks merged commit 04249aa into main Nov 17, 2020
@rekmarks rekmarks deleted the type-fixup branch November 17, 2020 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brad-decker brad-decker brad-decker approved these changes

@NiranjanaBinoy NiranjanaBinoy Awaiting requested review from NiranjanaBinoy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rekmarks @brad-decker