[Bug]: Signature fails with Ledger

[atillabirer]

Describe the bug

When we attempt to sign a message using ethersjs and Ledger, signing fails with Network Error in the console and the signature pop-up keeps coming back. The called contract reverts with a hex that basically says InvalidSignature() . Signing normally on browser (without ledger) works normally. Ledger with Trust wallet also works normally.

Steps to reproduce

1. Connect ledger to metamask
2. call any transaction that requires signing

Error messages or log output

No response

Version

10.25.0

Build type

None

Browser

Chrome, Firefox, Brave

Operating system

MacOS, Linux

Hardware wallet

Ledger

Additional context

No response

[danjm]

Can you share a code sample that we could run to reproduce the failure you are seeing?

[atillabirer]

handled it this way:

        const signature = await signer._signTypedData(domain, types, values)
        //replace 
        let {r,s,v} = utils.splitSignature(signature);
        console.log("rsv:",{r,s,v})
        if(v == 0) v = 27
        if(v == 1) v = 28
        console.log(utils.joinSignature({r,s,v}))
        const joined = utils.joinSignature({r,s,v});


        return { signature: joined, permit, witness }

but it would be good if metamask flipped v = 0,1 to v=27,28 when ledger returns the v as 0,1.

[plasmacorral]

This was resolved with MetaMask/eth-ledger-bridge-keyring#152