Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NewUI - Make gas price editable on confirm tx screen #3202

Closed
danfinlay opened this issue Feb 7, 2018 · 4 comments
Closed

NewUI - Make gas price editable on confirm tx screen #3202

danfinlay opened this issue Feb 7, 2018 · 4 comments
Assignees
@danjm
Labels
area-UI Relating to the user interface. needs-design Needs design support. type-discussion

Comments

@danfinlay
Copy link
Contributor

I know we've gone back and forth on this, but I'm taking the position that gas editing is fundamental enough that it belongs even on the final tx confirm screen. @cjeria
@danfinlay danfinlay added the area-UI Relating to the user interface. label Feb 7, 2018
@JohnAllen
Copy link

Isn't it already editable? One can click up and down and adjust the price and gas limit

@danfinlay
Copy link
Contributor Author

The NewUI tag refers to the uat branch.

@danjm danjm assigned danjm and unassigned kumavis Feb 26, 2018
@2-am-zzz 2-am-zzz removed the labeled label Mar 13, 2018
@kumavis kumavis changed the title NewUI - Make gas editable on confirm tx screen NewUI - Make gas price editable on confirm tx screen May 7, 2018
@danjm danjm mentioned this issue May 30, 2018
Closed
@bdresser
Copy link
Contributor

@danfinlay @danjm unless this is referring to a different screen, it seems like gas price is editable already:

screen shot 2018-05-30 at 4 27 36 pm

it does overlap with where it says ETH which i will file separately.

@danfinlay
Copy link
Contributor Author

I agree, looks like it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danjm danjm

Labels
area-UI Relating to the user interface. needs-design Needs design support. type-discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@danfinlay @bdresser @kumavis @2-am-zzz @JohnAllen @danjm