Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UX of gas estimation on send token screen #4662

Closed
danjm opened this issue Jun 25, 2018 · 0 comments · Fixed by #4690
Closed

Improve UX of gas estimation on send token screen #4662

danjm opened this issue Jun 25, 2018 · 0 comments · Fixed by #4690
Assignees
Labels
area-UI Relating to the user interface.

Comments

@danjm
Copy link
Contributor

danjm commented Jun 25, 2018

Currently, the send token screen estimates gas based on info the user has entered. So, if no recipient address or amount has been entered, we provide the best estimate we can with that info.

If an absence of info provided to estimateGas results in a failed simulation, we provide an estimate based on the blockGasLimit, which will be huge relative to what a user will be expecting. Such failures will be more likely when we are missing the recipient address.

We can improve the UX of gas estimation on the 'Send Token' screen by providing a base estimate that should cover all token sends, and then updating that estimate only once recipient address has been entered.

Users may still see jumps in estimates after they change the amount if they are sending to an address that does not yet have any of the token. I don't think that there is anything we can do about this, except that ideally our base estimate will be something that usually goes down as new info is added, but which never is extremely high (which it doesn't need to be in the case of a token send).

This will partly address issue (d) in #4645

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-UI Relating to the user interface.
Projects
None yet
1 participant