Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add advanced setting to enable editing nonce on confirmation screens #6757

Closed
danfinlay opened this issue Jun 26, 2019 · 2 comments
Closed
Labels
area-nonce Relating to tx nonce logic T08-featureRequest

Comments

@danfinlay
Copy link
Contributor

danfinlay commented Jun 26, 2019

This is a specific solution proposal that fixes #1410, for the sake of possibly adding a clean and simple bounty to.

Scope:

  1. A new setting should be added to app/scripts/controllers/preferences.js for whether a user wants a nonce field.
  2. This setting should be exposed as a toggle switch in the settings screen as "Show nonce field on confirmation screens. Only use if you understand the implications." (This message should be written in the i18n file).
  3. If this boolean is true, render a field on the tx confirmation screen that allows hard-coding this otherwise dynamically computed value. The placeholder text of the nonce field should say "Automatically calculate."

I will review this with our team for whether we want to add a bounty before we do, but I think for some advanced users it could clearly be a nice thing to expose.

@SCBuergel
Copy link

I'll chip in if you Gitcoin this one!

[Meta: "to Gitcoin", verb, adding a bounty on the popular Gitcoin platform]

@bdresser
Copy link
Contributor

bdresser commented Oct 7, 2019

handled in #7240

@bdresser bdresser closed this as completed Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-nonce Relating to tx nonce logic T08-featureRequest
Projects
None yet
Development

No branches or pull requests

4 participants