Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to delete contact from contact list. #7318

Closed
tmashuang opened this issue Oct 28, 2019 · 0 comments · Fixed by #7324
Closed

Unable to delete contact from contact list. #7318

tmashuang opened this issue Oct 28, 2019 · 0 comments · Fixed by #7324
Labels
type-bug Something isn't working

Comments

@tmashuang
Copy link
Contributor

tmashuang commented Oct 28, 2019

  1. Add a new contact with any name and a valid address,
  2. Go to contact list, select contact, Edit, Delete Account

Bug: Delete Account will not remove contact from the list. Any following actions; editing contact, going to main screen, etc. shows infinite loading spinner

Background Errors right when clicking Delete Account:

metamask-controller.js:1393 TypeError: Cannot read property 'toLowerCase' of undefined
    at Object.exports.toChecksumAddress (index.js:388)
    at AddressBookController.delete (AddressBookController.js:37)
    at Proto.apply (index.js:123)
    at Proto.handle (index.js:99)
    at dnode.handle (dnode.js:140)
    at dnode.write (dnode.js:128)
    at Substream.ondata (_stream_readable.js:612)
    at emitOne (events.js:106)
    at Substream.emit (events.js:184)
    at addChunk (_stream_readable.js:284)
    at readableAddChunk (_stream_readable.js:271)
    at Substream.Readable.push (_stream_readable.js:238)
    at ObjectMultiplex._write (index.js:68)
    at doWrite (_stream_writable.js:406)
    at writeOrBuffer (_stream_writable.js:395)
    at ObjectMultiplex.Writable.write (_stream_writable.js:322)
    at PortDuplexStream.ondata (_stream_readable.js:619)
    at emitOne (events.js:106)
    at PortDuplexStream.emit (events.js:184)
    at addChunk (_stream_readable.js:291)
    at readableAddChunk (_stream_readable.js:278)
    at PortDuplexStream.Readable.push (_stream_readable.js:245)
    at PortDuplexStream._onMessage (index.js:38)

Also: Contact Copy Address button is vertically stretched, probably from the svg PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant