Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn user when custom token addition has defaulted to 0 #9777

Closed
danjm opened this issue Nov 2, 2020 · 0 comments · Fixed by #10956
Closed

Warn user when custom token addition has defaulted to 0 #9777

danjm opened this issue Nov 2, 2020 · 0 comments · Fixed by #10956
Assignees
@NiranjanaBinoy
Labels
area-tokens needs-design Needs design support. Sev2-normal Normal severity; minor loss of service or inconvenience. type-bug Something isn't working ux-enhancement

Comments

@danjm
Copy link
Contributor

danjm commented Nov 2, 2020

Currently, when attemptToAutoFillTokenParams in add-token.component.js is called, if a network issue causes the decimals to default to 0, the user is not notified. This can lead to tokens being added with an erroneous decimals value of 0. Notifying the user that no decimal info was retrievable could prevent this. Perhaps even better we should require the user to directly input decimals in such cases.

These changes might have prevented the issue detailed in #9771
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NiranjanaBinoy NiranjanaBinoy

Labels
area-tokens needs-design Needs design support. Sev2-normal Normal severity; minor loss of service or inconvenience. type-bug Something isn't working ux-enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handling custom token decimal fetch failure due to network error MetaMask/metamask-extension
4 participants
@Gudahtt @danjm @jacobc-eth @NiranjanaBinoy