Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WatchAsset method: "Add suggested token" prompt doesn't show correct balance #2847

Closed
omnat opened this issue Jun 23, 2021 · 6 comments · Fixed by #2866
Closed

WatchAsset method: "Add suggested token" prompt doesn't show correct balance #2847

omnat opened this issue Jun 23, 2021 · 6 comments · Fixed by #2866
Assignees
@gantunesr
Labels
this issue is prioritized Story in develop or in release type-bug Something isn't working

Comments

@omnat
Copy link
Contributor

omnat commented Jun 23, 2021

As an example, if your wallet did have non-zero token balance on this token, it'll still show zero.

image.png
@omnat omnat added type-bug Something isn't working good-onboarding-story labels Jun 23, 2021
@omnat omnat changed the title WatchAsset method: "Add suggested token" prompt doesn't show balance WatchAsset method: "Add suggested token" prompt doesn't show correct balance Jun 23, 2021
@gantunesr gantunesr self-assigned this Jun 29, 2021
@ibrahimtaveras00
Copy link
Contributor

For QA reference = https://www.coingecko.com/en/coins/shiba-inu

@gantunesr
Copy link
Member

Bug related to a case sensitive match between the keys (address) associated with the token balance.

0x514910771bf9ca656af840dff83e8264ecf123nm != 0x514910771BF9Ca656af840dff83E8264EcF123NM

Quick fix: Case insensitive key match.
Proposed fix: Keep all address in lower case in controller.

Simulator Screen Shot - iPhone 11 Pro - 2021-07-04 at 20.09.58.png

@wachunei
Copy link
Member

wachunei commented Jul 5, 2021

Do you know where this comparison is being made? Is it on our end? If so we should use this function

@gantunesr
Copy link
Member

Yes, it's on mobile but can be fixed on either side. Great! I'll use that function

@gantunesr gantunesr linked a pull request Jul 9, 2021 that will close this issue
[2847] Bug in token balance #2866
Merged
@mobularay
Copy link
Contributor

PR: #2866

@omnat omnat added the this issue is prioritized Story in develop or in release label Jul 28, 2021
@gantunesr
Copy link
Member

UPDATE: I'm refactoring the component into a functional one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gantunesr gantunesr

Labels
this issue is prioritized Story in develop or in release type-bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[2847] Bug in token balance MetaMask/metamask-mobile
5 participants
@wachunei @gantunesr @ibrahimtaveras00 @omnat @mobularay