Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI] Keystone - Connect Wallet Flow review #3952

Closed
9 tasks done
holantonela opened this issue Mar 24, 2022 · 1 comment
Closed
9 tasks done

[UI] Keystone - Connect Wallet Flow review #3952

holantonela opened this issue Mar 24, 2022 · 1 comment
Assignees
@gantunesr
Labels
area-hardware area-UI release-5.3.0 Issue or pull request that will be included in release 5.3.0 team-accounts type-bug Something isn't working

Comments

@holantonela
Copy link

holantonela commented Mar 24, 2022 •
edited by gantunesr
Loading

REF
https://www.figma.com/file/7dE8BHjcoF7CYDfvKKz2Wx/MMM-%3C%3E-Keystone-UI-Review?node-id=0%3A1

General

  • Close icon is misaligned

Select Account

  • The input needs 8px margin. Also, the default checkbox component does not span the whole height. Please use it.
  • We need 16px of Y spacing between the list and the Prev/Next navigation buttons.
  • Typography should be in 16px for title and 14 px for content
  • Spacing between checkbox and content must be 16px
  • optimize the order of the content: name of the account as title, address subtitle
  • align cell with the title: "select an account"
  • grey background when cell is selected is not necessary and it doesn't look good
  • Size of icons must be between 32px or 24 px
@holantonela
Copy link
Author

Updated Table UI

image

@holantonela holantonela changed the title Connect wallet flow UI review [UI] Connect wallet flow review Mar 28, 2022
@holantonela holantonela mentioned this issue Mar 28, 2022
Closed
@holantonela holantonela changed the title [UI] Connect wallet flow review [UI] Keystone - Connect Wallet Flow review Mar 28, 2022
@gantunesr gantunesr mentioned this issue Apr 11, 2022
Merged
3 tasks
@mobularay mobularay added the release-5.3.0 Issue or pull request that will be included in release 5.3.0 label Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gantunesr gantunesr

Labels
area-hardware area-UI release-5.3.0 Issue or pull request that will be included in release 5.3.0 team-accounts type-bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@AlexJupiter @gantunesr @mobularay @holantonela