Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Swap button is displayed on not supported networks #6472

Closed
seaona opened this issue May 26, 2023 · 1 comment
Closed

[Bug] Swap button is displayed on not supported networks #6472

seaona opened this issue May 26, 2023 · 1 comment
Assignees
@nikoferro
Labels
regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead regression-RC-7.1.0 release-7.1.0 Issue or pull request that will be included in release 7.1.0 Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead type-bug Something isn't working

Comments

@seaona
Copy link
Contributor

seaona commented May 26, 2023 •
edited by leotm
Loading

Describe the bug
Whenever I am on a network which does not support Swaps, I can see how the Swap button is displayed and if I click it nothing happens.

Screenshots

swap-button-not-supported-nets.mp4

To Reproduce
Steps to reproduce the behavior

  1. Select any network which does not support Swaps (i.e. Goerli)
  2. Click on Goerli ETH
  3. See how Swap button is displayed

Expected behavior
Swap button should not be displayed on unsupported networks.

Smartphone (please complete the following information):

  • Device: Pixel 6
  • OS: android
  • App Version: v6.7

to be added after bug submission by internal support / PM
Severity

  • How critical is the impact of this bug on a user?
  • Add stats if available on % of customers impacted
  • Is this visible to all users?
  • Is this tech debt?
@seaona seaona added type-bug Something isn't working needs-triage Issues that require triage release-6.7.0 Issue or pull request that will be included in release 6.7.0 release-7.1.0 Issue or pull request that will be included in release 7.1.0 and removed release-6.7.0 Issue or pull request that will be included in release 6.7.0 labels May 26, 2023
@nikoferro nikoferro self-assigned this May 26, 2023
@nikoferro nikoferro mentioned this issue May 26, 2023
Merged
3 tasks
@anaamolnar anaamolnar added Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-mobile-client and removed needs-triage Issues that require triage labels May 29, 2023
@leotm leotm changed the title [Bug] Swapp button is displayed on not supported networks [Bug] Swap button is displayed on not supported networks Jun 6, 2023
@seaona seaona added the regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead label Jun 6, 2023
@cortisiko
Copy link
Member

was fixed in #6473

@gauthierpetetin gauthierpetetin added the team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead label Feb 2, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team May 15, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikoferro nikoferro

Labels
regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead regression-RC-7.1.0 release-7.1.0 Issue or pull request that will be included in release 7.1.0 Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead type-bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@gauthierpetetin @nikoferro @sethkfman @cortisiko @metamaskbot @seaona @anaamolnar and others