From 3556c3cc8fb5c65a0c0cc53f226b8483de5cd7cc Mon Sep 17 00:00:00 2001
From: Frederik Bolding <frederik.bolding@gmail.com>
Date: Fri, 14 Feb 2025 18:18:28 +0100
Subject: [PATCH] fix(simulation): Unintentionally narrow type for
 `onKeyringRequest` helper (#3109)

Fixes an unnecessarily narrow type for `onKeyringRequest` that makes it
seem like the request cannot produce interfaces.
---
 packages/snaps-simulation/src/helpers.ts | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/packages/snaps-simulation/src/helpers.ts b/packages/snaps-simulation/src/helpers.ts
index b1924e9656..2422ea8ccc 100644
--- a/packages/snaps-simulation/src/helpers.ts
+++ b/packages/snaps-simulation/src/helpers.ts
@@ -141,9 +141,7 @@ export type SnapHelpers = {
    * @param keyringRequest - Keyring request.
    * @returns The response.
    */
-  onKeyringRequest(
-    keyringRequest: KeyringOptions,
-  ): Promise<SnapResponseWithoutInterface>;
+  onKeyringRequest(keyringRequest: KeyringOptions): SnapRequest;
 
   /**
    * Get the response from the Snap's `onInstall` handler.
@@ -270,12 +268,10 @@ export function getHelpers({
     });
   };
 
-  const onKeyringRequest = async (
-    request: KeyringOptions,
-  ): Promise<SnapResponseWithoutInterface> => {
+  const onKeyringRequest = (request: KeyringOptions) => {
     log('Sending keyring request %o.', request);
 
-    const response = await handleRequest({
+    return handleRequest({
       snapId,
       store,
       executionService,
@@ -284,8 +280,6 @@ export function getHelpers({
       handler: HandlerType.OnKeyringRequest,
       request,
     });
-
-    return response;
   };
 
   return {