Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update [email protected] to 1.0.9 #252

Closed
ArthurGerbelot opened this issue Sep 26, 2017 · 7 comments
Closed

Update [email protected] to 1.0.9 #252

ArthurGerbelot opened this issue Sep 26, 2017 · 7 comments

Comments

@ArthurGerbelot
Copy link

Following the Meteor Allow-Deny Vulnerability Disclosure, the dependency to allow-deny in file roles/.versions should be updated to 1.0.9 to fix it.

@topleft
Copy link
Contributor

topleft commented Sep 26, 2017

+1

@alanning
Copy link
Contributor

Merged into master. What is the effect of the roles/.versions file pointing to the pre-patch version?

@topleft
Copy link
Contributor

topleft commented Sep 26, 2017

A vulnerability was found in which a specially formed payload sent over a web socket could gain access to updating docs in the DB.

https://forums.meteor.com/t/meteor-allow-deny-vulnerability-disclosure/39500

@topleft
Copy link
Contributor

topleft commented Sep 26, 2017

@alanning Will you update the Atmosphere package to reflect what is currently on master?

@alanning
Copy link
Contributor

I am aware of the vulnerability. The Roles package itself does not use allow/deny directly so it is not directly vulnerable to my knowledge.

I am wondering if I need to update the Atmosphere package. Not sure what effect, if any, having the older version in roles/.versions has. I would not anticipate it being a problem since people who actually use allow/deny will probably update their app to have the newest and then what's in the roles/.versions will be overwritten.

But this is all conjecture which is why I was asking to see if anyone had more concrete knowledge about this.

@mitar
Copy link
Member

mitar commented Sep 27, 2017

I am also unsure here if anything should be done. It is a patch bump. Anyone can just update it locally in their app. This package is not preventing that in any way.

@mitar
Copy link
Member

mitar commented Oct 3, 2019

I think this has been done.

@mitar mitar closed this as completed Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants