Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRA check fails. #115

Open
sorgelig opened this issue May 27, 2024 · 5 comments
Open

MRA check fails. #115

sorgelig opened this issue May 27, 2024 · 5 comments

Comments

@sorgelig
Copy link
Member

@theypsilon
it seems github deprecated Ubuntu 18 which affects this script:
https://raw.githubusercontent.com/MiSTer-devel/Scripts_MiSTer/master/other_authors/mra_rom_check.sh

So MRA validating gets failed now.

@theypsilon
Copy link
Member

Could you point me to a job that fails? I've been searching but don't recall which one could be affected

@sorgelig
Copy link
Member Author

@theypsilon
Copy link
Member

The issue is the runtime on GitHub actions' workflow, I've sent a PR to use Ubuntu latest instead of 18.04: MiSTer-devel/Arcade-Druaga_MiSTer#32

I already did this change in many workflows but this one was missing.

@sorgelig
Copy link
Member Author

sorgelig commented Jun 20, 2024

hmm.. I've thought it's centralized. Then there are some other repos with similar issue but it will be hard to find till i will get that error again.

@theypsilon
Copy link
Member

The runtime is defined in each workflow, and that affects whatever is being run by the task. I was surprised when GitHub dropped support for such a popular distro. Very disappointing, it basically forces all long-lasting GitHub Action users to move to ubuntu-latest which is not the best for build reproducibility. I already changed all the repos to which I have access.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants