Install of v1.6.0 fails on windows + mac

[SkafteNicki]

Describe the bug
Hi, Nicki from Torchmetrics team here. Thanks for the great work in this repository, we could not have implemented it our self which is why we gladly try to support it as backend.

Out CI is trying to update to v1.6.0 and we are seeing the installation of the package failing on both windows and mac, but working on ubuntu. See this:
PR: Lightning-AI/torchmetrics#2750
Failing mac build: https://github.com/Lightning-AI/torchmetrics/actions/runs/11252976351/job/31287372620?pr=2750
Failing windows build: https://github.com/Lightning-AI/torchmetrics/actions/runs/11252976351/job/31287373485?pr=2750

Any help on how to fix this will be appreciated.

To Reproduce
Steps to reproduce the behavior

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

[Borda]

@MiXaiLL76 will you have time to check this out? 🦩

[MiXaiLL76]

@MiXaiLL76 will you have time to check this out? 🦩

Hi! Thanks for the issue! I'll look into it as soon as possible and get back with a fix!
The thing is that I don't use windows & macos and can't catch such errors, but I'll start a virtual machine and try to repeat them

[MiXaiLL76]

#40
In general, I started a virtual machine with windows and checked everything in anaconda. Made the necessary corrections and now everything works.
For macos, I made a "blind fix", because I don't have macos at hand for debugging. Maybe this will solve the problem, or maybe you just need a more recent version of pybind11 (I didn't see which version you are trying to compile in ci\cd)

I will be glad if your team will help me to form a better ci\cd file for building the library, which will include macos & windows.
I am not very good at github actions, so I wrote what I could)

[MiXaiLL76]

#41

Regarding another bug, I wrote here

Lightning-AI/torchmetrics#2750 (comment)

[MiXaiLL76]

faster-coco-eval 1.6.2 Available on pypi.

[SkafteNicki]

Can confirm v1.6.2 installs on my local windows machine

[MiXaiLL76]

How are the build tests? Does everything work on macos and windows?

[SkafteNicki]

@MiXaiLL76 all windows builds are now installing and passing, but all macos builds are still failing at the installation:
https://github.com/Lightning-AI/torchmetrics/actions/runs/11271068805/job/31343173001?pr=2750

[MiXaiLL76]

@MiXaiLL76 all windows builds are now installing and passing, but all macos builds are still failing at the installation: https://github.com/Lightning-AI/torchmetrics/actions/runs/11271068805/job/31343173001?pr=2750

Can you tell me what version of pybind11 is being used?

[MiXaiLL76]

With macos it's some kind of compiler problem, very strange. I found a laptop with macos and took it for the evening, I can do tests.

[MiXaiLL76]

I am happy to announce that I have solved the problem with macOS!
It was an interesting investigation) And a very small fix)

Soon I will post release 1.6.3 and everything will work

https://github.com/MiXaiLL76/faster_coco_eval/pull/42/files#diff-8e664d578574d7ecb2472b5af8bfa2d557c238d55d770a1c75b7215f7c1f3303R146