urllib.error.HTTPError: HTTP Error 403: Forbidden

[wegank]

As the failure isn't caught, nixpkgs-review can't fall back to ofborg when no GH token is provided...

$ nixpkgs-review pr 369784
no oauth token found for github.com
-> Attempting to fetch eval results from GitHub actions
$ git worktree remove -f /home/weijia/.cache/nixpkgs-review/pr-369784/nixpkgs
fatal : '/home/weijia/.cache/nixpkgs-review/pr-369784/nixpkgs' n'est pas une copie de travail
Failed to remove worktree at /home/weijia/.cache/nixpkgs-review/pr-369784/nixpkgs. Please remove it manually. Git failed with: 128
Traceback (most recent call last):
  File "/nix/store/8b1i931y4hz4s0inp95fvh328ay522f8-nixpkgs-review-3.0.0/bin/.nixpkgs-review-wrapped", line 9, in <module>
    sys.exit(main())
             ^^^^^^
  File "/nix/store/8b1i931y4hz4s0inp95fvh328ay522f8-nixpkgs-review-3.0.0/lib/python3.12/site-packages/nixpkgs_review/__init__.py", line 10, in main
    cli.main(command, args)
  File "/nix/store/8b1i931y4hz4s0inp95fvh328ay522f8-nixpkgs-review-3.0.0/lib/python3.12/site-packages/nixpkgs_review/cli/__init__.py", line 348, in main
    return cast(str, args.func(args))
                     ^^^^^^^^^^^^^^^
  File "/nix/store/8b1i931y4hz4s0inp95fvh328ay522f8-nixpkgs-review-3.0.0/lib/python3.12/site-packages/nixpkgs_review/cli/pr.py", line 97, in pr_command
    contexts.append((pr, builddir.path, review.build_pr(pr)))
                                        ^^^^^^^^^^^^^^^^^^^
  File "/nix/store/8b1i931y4hz4s0inp95fvh328ay522f8-nixpkgs-review-3.0.0/lib/python3.12/site-packages/nixpkgs_review/review.py", line 300, in build_pr
    packages_per_system = self.github_client.get_github_action_eval_result(pr)
                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/8b1i931y4hz4s0inp95fvh328ay522f8-nixpkgs-review-3.0.0/lib/python3.12/site-packages/nixpkgs_review/github.py", line 182, in get_github_action_eval_result
    changed_paths: Any = self.get_json_from_artifact(
                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/8b1i931y4hz4s0inp95fvh328ay522f8-nixpkgs-review-3.0.0/lib/python3.12/site-packages/nixpkgs_review/github.py", line 119, in get_json_from_artifact
    with no_redirect_opener.open(req) as resp:
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/c9m6yd8fg1flz2j5r4bif1ib5j20a0cy-python3-3.12.8/lib/python3.12/urllib/request.py", line 521, in open
    response = meth(req, response)
               ^^^^^^^^^^^^^^^^^^^
  File "/nix/store/c9m6yd8fg1flz2j5r4bif1ib5j20a0cy-python3-3.12.8/lib/python3.12/urllib/request.py", line 630, in http_response
    response = self.parent.error(
               ^^^^^^^^^^^^^^^^^^
  File "/nix/store/c9m6yd8fg1flz2j5r4bif1ib5j20a0cy-python3-3.12.8/lib/python3.12/urllib/request.py", line 559, in error
    return self._call_chain(*args)
           ^^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/c9m6yd8fg1flz2j5r4bif1ib5j20a0cy-python3-3.12.8/lib/python3.12/urllib/request.py", line 492, in _call_chain
    result = func(*args)
             ^^^^^^^^^^^
  File "/nix/store/c9m6yd8fg1flz2j5r4bif1ib5j20a0cy-python3-3.12.8/lib/python3.12/urllib/request.py", line 639, in http_error_default
    raise HTTPError(req.full_url, code, msg, hdrs, fp)
urllib.error.HTTPError: HTTP Error 403: Forbidden

[Mic92]

I don't think we can fallback any longer to ofborg anyway except for old cached pull requests. The new ofborg infra likely won't do any evaluation.

[wegank]

Alright, thanks for the explanation. I think this issue can be closed.

[Mic92]

We should improve the http error though

[Mic92]

Now the error is better.