Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid Collision with user environment variables #17

Open
MichaReiser opened this issue Nov 16, 2016 · 0 comments
Open

Avoid Collision with user environment variables #17

MichaReiser opened this issue Nov 16, 2016 · 0 comments

Comments

@MichaReiser
Copy link
Owner

MichaReiser commented Nov 16, 2016

The extracted environment variables might collide with variables defined by the user:

const x = 100;

parallel.from([1, 2, 3])
  .inEnvironment({ x: 10 })
  .map((value, env) => value * x * env.x);

The easiest approach is to use "ugly" names for the variables extracted in the environment hash. E.g. _______parallel-es-extracted-closure-variable________x. This should reduce collisions to a minimum.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant