Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

introduce gsl::not_null<T>::element_type #1196

Merged
merged 3 commits into from
Feb 12, 2025
Merged

introduce gsl::not_null<T>::element_type #1196

merged 3 commits into from
Feb 12, 2025
+23 −0

Conversation

carsonRadtke
Copy link
Collaborator

fixes: #1186

@carsonRadtke carsonRadtke merged commit ec729d6 into microsoft:main Feb 12, 2025
83 checks passed
@carsonRadtke carsonRadtke deleted the gsl-null-element-type branch February 12, 2025 15:16
@beinhaerter
Copy link
Contributor

The commit message contains
"* use std::is_same instead of is_same_v

  • fix: cannot put a non-pointer in a gsl::not_null"

Both is nothing that this merge request changed.

beinhaerter
beinhaerter reviewed Feb 27, 2025
View reviewed changes
docs/headers.md
using element_type = T;
```

The type of the pointed-to object.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong. T is a raw pointer or a smart pointer, but not the type of the pointed to object.

@BrewTestBot BrewTestBot mentioned this pull request Mar 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beinhaerter beinhaerter beinhaerter left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add element_type to not_null
2 participants
@carsonRadtke @beinhaerter