TypedArrays missing signature

[sebdoucet]

Hi,

Is it wanted this signature is not availlable in default lib.ts on all typed array :

set(array: Array<number>, offset?: number): void;

I don't look to specs, but it's working everywhere on typed arrays and it's not the case for other methods like fill, reverse, foreach, etc.

It's not a big deal to had this on a custom missing signature file, but it doen t make sence for me having stuff that doesn t work and not stuff that already work.

Regards.

[danquirk]

Signatures here do seem wrong.

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/TypedArray/set

typedarr.set(array [,offset])
typedarr.set(typedarray [,offset])

whereas our definition for Uint8Array has these two signatures:

set(index: number, value: number): void;
set(array: Uint8Array, offset?: number): void;

[Eyas]

What is the correct resolution here? The current core.d.ts has:

set(index: number, value: number): void;
set(array: ArrayLike<number>, offset?: number): void;

The second variable takes care of both MDN cases:

typedarr.set(array [,offset])
typedarr.set(typedarray [,offset])

Judging by the MDN link, we should simply remove the first overload. MSDN, on the other hand, claims that this overload is valid:

uint8Array.set(index, value);
uint8Array.set(array, offset);

If MSDN is right, then there is no valid work item for this issue; it should be closed. If MDN is right, then we should change this ticket to refer to removing the first overload, and resolve it accordingly.

[DanielRosenwasser]

Sounds like this is fixed; @zhengbli can you confirm?

[zhengbli]

This is fixed by 20902b0, which added another signature to all the typed arrays:
set(array: ArrayLike<number>, offset?: number): void;