Add ability to customize default implementation of bonded<T> in C# #153
Conversation
|
The AppVeyor build appears to have failed during We still need to figure out the Travis CI build issue (issue #154), so this won't get merged until then anyway. I'll look into these failures tomorrow or find someone to help me. |
|
We've figure out the Mono test failures. lalo is working on a fix. Details in #154. |
|
|
||
|
|
||
| /// <summary> | ||
| /// Create a cloner that makes clones of the same type SourceT as source objects. |
There was a problem hiding this comment.
- Minor: in the doc comment's let's make sure that we're using
seeorparamrefortypeparamrefand so on when referring to other types or parameters.
This change will need to be made in a number of places across a number of files.
|
Heads up that this change and #146 are very likely to conflict with each other. I'll merge them in the order that the get completed in, so consider this an incentive to respond to feedback quickly. :-) |
|
Rebasing my changes on top of a9c4d78 |
| /// </summary> | ||
| private class CustomTransformFactory | ||
| { | ||
| public static readonly CustomTransformFactory Default = new CustomTransformFactory(); |
There was a problem hiding this comment.
- Minor:
Instanceinstead ofDefault, as there's no way to create a custom one of these.
|
Thanks. Just a few more comments to be addressed. |
|
LGTM. Will merge this when CI passes. |
Add ability to specify custom implementations of
bonded<T>given:TRuntimeSchemaFixes the inability to support custom
Serializer/Deserializer/Cloner/Transcoderwithinbonded<T>