when there is only one project matching the mainclass, projectName is not required for evaluation. #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaohaizh
reviewed
Mar 14, 2018
| @@ -14,4 +14,5 @@ | |||
| public final class Constants { | |||
| public static final String PROJECTNAME = "projectName"; | |||
| public static final String DEBUGGEE_ENCODING = "debuggeeEncoding"; | |||
| public static final String MAINCLASS = "mainClass"; | |||
There was a problem hiding this comment.
Done with the same issue fixed for project name
yaohaizh
reviewed
Mar 14, 2018
| * | ||
| * @param mainclass the main class specified by launch.json for finding possible projects | ||
| */ | ||
| private void initializePossibleProjects(String mainclass) { |
There was a problem hiding this comment.
initializeProjectCandidates
yaohaizh
reviewed
Mar 14, 2018
| // ignore | ||
| } | ||
|
|
||
| logger.severe("Cannot evaluate when project is not specified."); |
There was a problem hiding this comment.
"Cannot evaluate when the project is not specified
yaohaizh
approved these changes
Mar 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.