This repository has been archived by the owner on Jun 6, 2024. It is now read-only.
check api resources before install proxy #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hao1939
approved these changes
Aug 30, 2018
ydye
reviewed
Aug 30, 2018
| @@ -197,6 +197,9 @@ def run(self): | |||
| kubectl_install_instance = kubectl_install.kubectl_install(self.cluster_config) | |||
| kubectl_install_instance.run() | |||
|
|
|||
| # check the registerd api resources | |||
| common.execute_shell("kubectl api-resources", "kubectl command failed!") | |||
There was a problem hiding this comment.
Maybe you should retry util successful
hao1939
reviewed
Aug 30, 2018
| common.execute_shell_retry("kubectl api-resources", "kubectl command failed!", 5) | ||
|
|
||
| # create kube-proxy until daemonset resource is registerd | ||
| common.execute_shell_retry("kubectl api-resources | grep -q daemonsets", "Controller manager hasn't create daemonset object!", 5) |
There was a problem hiding this comment.
- Will
kubectl api-resources | grep -q daemonsetsreturn none zero when daemonsets not ready? - Does the grep -q case-sensitive?
There was a problem hiding this comment.
yes, only when it grep nothing it return 0, I have test
There was a problem hiding this comment.
kubectl api-resources results are all lowercase, the "grep" is case-sensitive
hao1939
approved these changes
Aug 30, 2018
|
Fixes #1153 |
hao1939
force-pushed
the
yife/check_resource
branch
3 times, most recently
from
a8c4ec7 to
52d0832
Compare
hao1939
force-pushed
the
yife/check_resource
branch
from
52d0832 to
e26bcf6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue #1153