This repository has been archived by the owner on Jun 6, 2024. It is now read-only.
Fix pod keeps retrying pull image
#1227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydye
reviewed
Aug 31, 2018
| @@ -48,4 +48,5 @@ docker run \ | |||
| --logtostderr=true \ | |||
| --pod-infra-container-image {{ clusterconfig['dockerregistry'] }}/pause-amd64:3.0 \ | |||
| --eviction-hard="memory.available<5%,nodefs.available<5%,imagefs.available<5%,nodefs.inodesFree<5%,imagefs.inodesFree<5%" \ | |||
| --image-pull-progress-deadline=6m \ | |||
There was a problem hiding this comment.
6m is enough? Maybe, this time should be longer?
There was a problem hiding this comment.
It's enough for now.
We may add a configuration entry later, maybe in another PR.
Hi @ydye , can we merge this PR first?
There was a problem hiding this comment.
Cool, I will update.
There was a problem hiding this comment.
If no pulling progress is made before this deadline, the image pulling will be cancelled. What will happen if the pulling canceled?
There was a problem hiding this comment.
@YitongFeng , it will retry.
If lucky, next retry may succeed, or it won't succeed forever.
YitongFeng
approved these changes
Aug 31, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1226