Skip to content
This repository has been archived by the owner on Jun 6, 2024. It is now read-only.

Add feedback with current version #1289

Merged
merged 4 commits into from
Sep 12, 2018
Merged

Conversation

Gerhut
Copy link
Member

@Gerhut Gerhut commented Sep 5, 2018

Closed #1122

image

When clicking the "Feedback", a GitHub "new issue" page will be opened with version label already set, since the labels of an issue are not easier to be removed by the issuer than the title or body. However, the label of version must be created before, otherwise, there will be no label assigned automatically.

image

I edit the version field in package info of REST server and web portal to match the version of the system, does pom.xml of launcher also need? @yqwang-ms

There will be 2 more steps in the release process:

  1. Modify the version field in the package.json of REST server and web portal.
  2. Create the version label on GitHub issue.

Theoretically, a Travis validation task could be added on pai-v-prefixed branch to ensure them.

@coveralls
Copy link

coveralls commented Sep 5, 2018

Coverage Status

Coverage increased (+11.5%) to 75.085% when pulling 4476420 on qixcheng/webportal/add-version into a17f154 on master.

@Gerhut Gerhut requested a review from scarlett2018 September 6, 2018 02:12
@@ -1,6 +1,6 @@
{
"name": "pai-rest-server",
"version": "0.1.0",
"version": "0.8.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will approve the PR first.
is it possible to get the version automatically from the release branch name?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fanyangCS Currently there is no third part "y" in branch name "pai-0.7.y", so we can only validate the version field on release branches but cannot auto generate it.

BTW, I used git describe HEAD as temporary version names in some early practices, which includes latest tag, commits count since latest tag and current commit hash. Unfortunately, it is not match our git flow, a little, since our release tags is not on the master branch.

Our git describe --tags master now looks like v0.5.0-822-ga17f1548, but git describe --tags v0.7.1 is v0.7.1(add --tags because we are using lightweight tags but not annotated tags for release versions), does that look fine?

@Gerhut Gerhut merged commit 13d35df into master Sep 12, 2018
@Gerhut Gerhut deleted the qixcheng/webportal/add-version branch September 12, 2018 10:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the release version of the current deployment
3 participants