This repository has been archived by the owner on Jun 6, 2024. It is now read-only.
Add Resubmit feature #1448
Merged
Add Resubmit feature #1448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gerhut
suggested changes
Sep 29, 2018
Gerhut
reviewed
Sep 29, 2018
src/webportal/src/app/job/job-view/job-detail-table.component.ejs
Outdated
Show resolved
Hide resolved
| $(document).on('click', '#resubmitjob_btn', () => { | ||
| let url; | ||
| let configYaml = yaml.safeLoad(configInfo); | ||
| let username = $('#nav-username').text(); |
There was a problem hiding this comment.
Use cookies.get("user") to get the current user without introduce other element ids
Gerhut
reviewed
Sep 29, 2018
| <% } %> | ||
| <button class="btn btn-default btn-xs" id="resubmitjob_btn" onclick="cloneJob()">Clone</button> |
There was a problem hiding this comment.
clonejob('<%= namespace %>', '<%= jobName %>')
Gerhut
reviewed
Sep 29, 2018
| @@ -36,8 +36,9 @@ | |||
| <% if (hjss === 'Waiting' || hjss === 'Running') { %> | |||
| <button class="btn btn-default btn-xs" onclick="stopJob('<%= namespace %>', '<%= jobName %>')">Stop</button> | |||
| <% } else { %> | |||
| <button class="btn btn-default btn-xs" disabled>Stop</button> | |||
| <button class="btn btn-default btn-xs" disabled>Stop</button> | |||
There was a problem hiding this comment.
Is the tailing whitespace required?
Gerhut
approved these changes
Sep 29, 2018
Gerhut
approved these changes
Sep 29, 2018
There was a problem hiding this comment.
@YitongFeng Make a little change in cloneJob, feel free to merge after test.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Resubmit feature at job detail page, after click it it will direct to submit job page, and automatically fill the form
Update: login user can resubmit other users' jobs, changed 'resubmit' to 'clone'