This repository has been archived by the owner on Jun 6, 2024. It is now read-only.
Upgrade Node.js version of webportal & rest server to 8 (Carbon) #1453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
Gerhut
force-pushed
the
qixcheng/upgrade-node-js-8
branch
from
8834d55 to
572c6ab
Compare
Gerhut
commented
Oct 11, 2018
| @@ -66,7 +66,7 @@ matrix: | |||
| - npm run coveralls | |||
|
|
|||
| - language: node_js | |||
| node_js: 7 | |||
| node_js: node | |||
There was a problem hiding this comment.
Ref: https://github.com/creationix/nvm/blob/master/README.md#usage node version means the latest version of node.js
Gerhut
commented
Oct 11, 2018
| @@ -55,7 +55,7 @@ matrix: | |||
| - mvn clean test jacoco:report coveralls:report | |||
|
|
|||
| - language: node_js | |||
| node_js: 6 | |||
| node_js: lts/carbon | |||
There was a problem hiding this comment.
Unify the travis test version as LTS name version, which has been already used in Dockerfile (FROM node:carbon)
Gerhut
force-pushed
the
qixcheng/upgrade-node-js-8
branch
from
dab0d2e to
bd9c8d5
Compare
Gerhut
force-pushed
the
qixcheng/upgrade-node-js-8
branch
from
bd9c8d5 to
e50457c
Compare
wangcan0329
approved these changes
Nov 16, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
npm run yarn(which stands foryarn --ignore-engines) toyarndirectly